-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functions to convolve simple distributions #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, next step to think of are tests.
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 73.94% 77.03% +3.09%
==========================================
Files 107 110 +3
Lines 5269 5235 -34
==========================================
+ Hits 3896 4033 +137
+ Misses 1373 1202 -171
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding these!
BTW Should we add that here? maybe @mschauer has thoughts? |
I think convolve leads to less ambiguity, but would be ok with |
In any case this could go in another PR |
alright, I think we can merge this as soon as travis passes, check if you want some last modifications |
just cleaned up the comments. merge when ready! |
These are simple functions to convolve distributions where a closed form exists.
Edit: taken essentially from this list: https://en.wikipedia.org/wiki/List_of_convolutions_of_probability_distributions
Please advise if this is the correct place to put them or if somewhere else would be more suitable.