Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize package and update CI #43

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

amontoison
Copy link
Member

No description provided.

@tkonolige
Copy link
Collaborator

Thanks @amontoison! Could you remove CompatHelper and TagBot from this PR and add them in a new PR? I don't have permissions to generate an ssh key for them. Could you also add testing for 1.8.

@amontoison
Copy link
Member Author

amontoison commented Nov 27, 2022

Thanks @amontoison! Could you remove CompatHelper and TagBot from this PR and add them in a new PR? I don't have permissions to generate an ssh key for them. Could you also add testing for 1.8.

1 means the last release of Julia (1.8.3) for information in ci.yml.
It avoids to update CI scripts every release.
I open a different PR for CI scripts.

@amontoison
Copy link
Member Author

amontoison commented Nov 27, 2022

Thanks @amontoison! Could you remove CompatHelper and TagBot from this PR and add them in a new PR? I don't have permissions to generate an ssh key for them. Could you also add testing for 1.8.

I will ask on Slack if someone can generate a ssh key.

@rayegun
Copy link
Member

rayegun commented Nov 27, 2022

I should have just added the keys, let me know if there are any issues. Once everything is set up I can also put the docs on the JuliaSparse domain.

@amontoison
Copy link
Member Author

Thanks Will !
Can you verify that GitHub Actions are activated in the settings?
I don't see any build in #45.
I will also a docs folder tomorrow for the documentation.

@rayegun
Copy link
Member

rayegun commented Nov 27, 2022

Not sure why it's not running yet either :/, I'll investigate more in the morning as well.

@tkonolige tkonolige merged commit 570c6d4 into JuliaSparse:master Nov 28, 2022
@amontoison amontoison deleted the modernize branch December 15, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants