Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An implementation of FGMRES #636

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Conversation

amontoison
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 97.99% // Head: 98.05% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (97f2e73) compared to base (66e1fd1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 97f2e73 differs from pull request most recent head e763db8. Consider uploading reports for the commit e763db8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   97.99%   98.05%   +0.06%     
==========================================
  Files          36       37       +1     
  Lines        6120     6310     +190     
==========================================
+ Hits         5997     6187     +190     
  Misses        123      123              
Impacted Files Coverage Δ
src/fgmres.jl 100.00% <100.00%> (ø)
src/krylov_solvers.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
Percival.jl
RipQP.jl

@amontoison
Copy link
Member Author

amontoison commented Sep 21, 2022

Example:

A = rand(20, 20)
b = rand(20)
N = LinearOperator(Float64, 20, 20, false, false, (y, x) -> y .= rand(20))  # Random preconditioner
x, stats = fgmres(A, b, N=N)
norm(b - A * x)
1.2601303680448969e-10

@amontoison
Copy link
Member Author

@dpo Can you just check the docstring of FGMRES?

amontoison and others added 3 commits September 25, 2022 20:09
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison amontoison merged commit 837f7c9 into JuliaSmoothOptimizers:main Sep 26, 2022
@amontoison amontoison deleted the fgmres branch September 26, 2022 01:15
@amontoison
Copy link
Member Author

Thanks for the review @dpo!

@amontoison amontoison mentioned this pull request Sep 26, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants