Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make experiments GPU compatible #549

Merged
merged 6 commits into from
Nov 20, 2021
Merged

Make experiments GPU compatible #549

merged 6 commits into from
Nov 20, 2021

Conversation

findmyway
Copy link
Member

@findmyway findmyway commented Nov 18, 2021 •
edited
Loading

The main idea is that we need to transfer data from CPU to GPU earlier, otherwise SubArray and ReshapedArray are not well handled on GPU.

@findmyway findmyway requested a review from albheim November 18, 2021 10:43
albheim
albheim approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@albheim albheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@findmyway findmyway changed the title Fix bug in GPU version of A2C and PPO Make experiments GPU compatible Nov 20, 2021
@findmyway findmyway enabled auto-merge (squash) November 20, 2021 04:34
@findmyway findmyway merged commit f4cf555 into JuliaReinforcementLearning:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albheim albheim albheim approved these changes

Assignees
No one assigned
Labels
Integration Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findmyway @albheim