Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make general components #370

Merged
merged 9 commits into from
Jul 17, 2021

Conversation

pilgrimygy
Copy link
Member

Put GaussianNetwork and DuelingNetwork into RLCore as general components. And make a general evaluate function.

Copy link
Member

@findmyway findmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remember to update NEWS.md.
  2. The failure in CI seems to be unrelated to this PR. I'll take a look into it.

@pilgrimygy pilgrimygy requested a review from findmyway July 16, 2021 02:25
@findmyway findmyway linked an issue Jul 16, 2021 that may be closed by this pull request
@findmyway
Copy link
Member

It's quite strange that the tests now run much slower...

@pilgrimygy
Copy link
Member Author

Thanks @findmyway for finding so many bugs!

@findmyway
Copy link
Member

findmyway commented Jul 17, 2021

@pilgrimygy could you confirm that the JuliaRL_BasicDQN_CartPole experiment in this PR can be finished in less than a minute?

It seems everything works as usual on my local machine. Not sure why it is so slow in CI.

Now I get it. Will fix it soon.

@pilgrimygy
Copy link
Member Author

Well. Why JuliaRL_BasicDQN_CartPole in CI is too slow?

@findmyway
Copy link
Member

I must say, this is the weirdest thing I've seen in Julia so far. And I really don't know why...

(@v1.6) pkg> activate src/ReinforcementLearningExperiments/

(ReinforcementLearningExperiments) pkg> build

(ReinforcementLearningExperiments) pkg> test

┌ Warning: `InplaceableThunk(t::Thunk, add!)` is deprecated, use `InplaceableThunk(add!, t)` instead.
│   caller = ip:0x0
└ @ Core :-1

Then it is stuck. Just like what we see in the CI.

Well, if we run it in REPL:

(@v1.6) pkg> activate src/ReinforcementLearningExperiments/

julia> using ReinforcementLearningExperiments

julia> ex = E`JuliaRL_BasicDQN_CartPole`;

julia> run(ex)

Things work as usual.

@findmyway findmyway merged commit 32aa394 into JuliaReinforcementLearning:master Jul 17, 2021
@pilgrimygy pilgrimygy deleted the component branch July 17, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can evaluate function be used as a component of RLcore?
2 participants