Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting repo namespace for GitLab #334

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix getting repo namespace for GitLab #334

merged 1 commit into from
May 5, 2021

Conversation

nkottary
Copy link
Member

@nkottary nkottary commented May 3, 2021

repo.namespace is always present but repo.owner can sometimes be nothing

@vdayanand vdayanand requested a review from DilumAluthge May 4, 2021 15:21
@DilumAluthge
Copy link
Member

I'm not as familiar with the GitLab API, but it looks right to me.

BTW, why is CI not running?

@fredrikekre
Copy link
Member

Probably the free Travis time is used already

@nkottary nkottary merged commit 8478973 into JuliaRegistries:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge Awaiting requested review from DilumAluthge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkottary @DilumAluthge @fredrikekre