Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Display reason when user is unauthorized #313

Merged

Conversation

arnaudh
Copy link
Contributor

@arnaudh arnaudh commented Dec 11, 2020

Having a go at #312

Quite new to Julia so not sure the code I wrote is idomatic.

Added tests for isauthorized, using Mocking.jl to mock the calls to GitHub/GitLab.

@arnaudh arnaudh changed the title Display reason when user is unauthorized WIP Display reason when user is unauthorized Dec 11, 2020
@nkottary
Copy link
Member

#314 should fix the tests.

@arnaudh arnaudh force-pushed the ah/more-info-when-unauthorized branch 2 times, most recently from 746f20c to 0542076 Compare December 24, 2020 08:19
@arnaudh arnaudh force-pushed the ah/more-info-when-unauthorized branch from f4c0a1f to 09ead1c Compare January 4, 2021 16:43
@arnaudh arnaudh changed the title WIP Display reason when user is unauthorized Display reason when user is unauthorized Jan 4, 2021
@arnaudh arnaudh force-pushed the ah/more-info-when-unauthorized branch from 09ead1c to c1957a1 Compare January 4, 2021 16:54
@arnaudh arnaudh changed the title Display reason when user is unauthorized WIP Display reason when user is unauthorized Jan 4, 2021
@nkottary nkottary merged commit 840bb46 into JuliaRegistries:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants