Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JuliaRegistrator removes labels from a registration PR when it updates it #308

Closed
ericphanson opened this issue Oct 15, 2020 · 3 comments · Fixed by #348
Closed

JuliaRegistrator removes labels from a registration PR when it updates it #308

ericphanson opened this issue Oct 15, 2020 · 3 comments · Fixed by #348
Labels
bug Something isn't working

Comments

@ericphanson
Copy link
Member

e.g. JuliaRegistries/General#22879
@fredrikekre
Copy link
Member

I think we use https://docs.github.com/en/free-pro-team@latest/rest/reference/issues#update-an-issue but should probably use https://docs.github.com/en/free-pro-team@latest/rest/reference/issues#add-labels-to-an-issue

@DilumAluthge
Copy link
Member

Bump. Is there any update on this?

@DilumAluthge
Copy link
Member

@ericphanson and I would like to use labels to streamline AutoMerge a little bit. But that will be inconvenient if Registrator keeps removing labels.

This was referenced Aug 30, 2021
Merged
Merged
@DilumAluthge DilumAluthge added the bug Something isn't working label Aug 31, 2021
nkottary pushed a commit that referenced this issue Sep 2, 2021
@ericphanson
Only remove labels we've added (#348)
d6a96c2 
Fix #308, Handle adding/removing labels on PRs correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only remove labels we've added JuliaRegistries/Registrator.jl
3 participants
@DilumAluthge @ericphanson @fredrikekre