Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Registrator v1.0.0 #3966

Merged
merged 1 commit into from
Oct 4, 2019
Merged

New version: Registrator v1.0.0 #3966

merged 1 commit into from
Oct 4, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 1, 2019 •
edited
Loading

@JuliaRegistrator JuliaRegistrator mentioned this pull request Oct 1, 2019
Closed
@christopher-dG
Copy link
Member

I would probably argue against ever releasing v1 of Registrator, since I assume it won't actually follow semver.

@StefanKarpinski
Copy link
Contributor

Or just bump the major version often.

@davidanthoff
Copy link
Contributor

Yes, 1.0.0 is perfectly fine from my end, main thing would just be to get it tagged, I've been trying to get a tag for 20 days now :) Frequent bumps of major versions seem perfectly fine to me.

@caseykneale caseykneale mentioned this pull request Oct 2, 2019
Merged
@fredrikekre
Copy link
Member

Lets include JuliaRegistries/Registrator.jl#228

@JuliaRegistrator JuliaRegistrator force-pushed the registrator/registrator/4418983a/v1.0.0 branch from 719f0b7 to d6d211a Compare October 3, 2019 05:22
@JuliaRegistrator
New version: Registrator v1.0.0
714b88f 
UUID: 4418983a-e44d-11e8-3aec-9789530b3b3e
Repo: https://github.com/JuliaRegistries/Registrator.jl.git
Tree: 0dc917d3370553aebe50b80bdff9142e665a021c

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/registrator/4418983a/v1.0.0 branch from d6d211a to 714b88f Compare October 3, 2019 08:00
@JuliaRegistrator JuliaRegistrator mentioned this pull request Oct 3, 2019
Closed
@KristofferC
Copy link
Member

JuliaRegistries/Registrator.jl#230 eeeeeh

@StefanKarpinski
Copy link
Contributor

I'm not following if I should merge this or not...

@nkottary nkottary merged commit 6abea79 into master Oct 4, 2019
@nkottary nkottary deleted the registrator/registrator/4418983a/v1.0.0 branch October 4, 2019 05:31
@julia-tagbot
Copy link

julia-tagbot bot commented Oct 4, 2019

I've created release v1.0.0, here it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-dG christopher-dG christopher-dG approved these changes

Assignees
No one assigned
Labels
waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JuliaRegistrator @christopher-dG @StefanKarpinski @davidanthoff @fredrikekre @KristofferC @nkottary