Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SEAL v0.1.0 #16920

Merged
merged 1 commit into from
Jun 28, 2020
Merged

New package: SEAL v0.1.0 #16920

merged 1 commit into from
Jun 28, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: bac81e26-86e4-4b48-8696-7d0406d5dbc1
Repo: https://github.com/sloede/SEAL.jl.git
Tree: 75dacb9cbbd05f0a62aebb90f718bec0d7dac1e7

Registrator tree SHA: 58e84c9733c0606ca53349dbce519209d8a8402b
JuliaRegistrator referenced this pull request in JuliaCrypto/SEAL.jl Jun 24, 2020
@github-actions
Copy link
Contributor

Your new package pull request does not meet the following guidelines for auto-merging:

  • Name does not meet all of the following: starts with an uppercase letter, ASCII alphanumerics only, not all letters are uppercase.
  • Name is not at least five characters long

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@sloede
Copy link
Contributor

sloede commented Jun 24, 2020

This package does not follow the rules for automatic merging of pull requests due to its nonstandard name: SEAL both too short (less than five characters) and all-capitalized. However, I tried to follow the Package naming guidelines, which states that

Packages that wrap external libraries or programs should be named after those libraries or programs

Since this package wraps the SEAL library, I decided to use SEAL to make this connection explicit in the name.
[noblock]

@sloede
Copy link
Contributor

sloede commented Jun 28, 2020

bump

Since the three-day waiting period has passed, it would be great if this can be merged.

[noblock]

@giordano giordano merged commit 76a6670 into master Jun 28, 2020
@giordano giordano deleted the registrator/seal/bac81e26/v0.1.0 branch June 28, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants