-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: NumExpr v1.0.0 #101894
New package: NumExpr v1.0.0 #101894
Conversation
JuliaRegistrator
commented
Feb 28, 2024
- Registering package: NumExpr
- Repository: https://github.com/bhftbootcamp/NumExpr.jl
- Created by: @DeevsDeevs
- Version: v1.0.0
- Commit: 6f570155fbd0d72c0b11ab7e602cbd67e358efea
- Reviewed by: @DeevsDeevs
- Reference: bhftbootcamp/NumExpr.jl@6f57015#commitcomment-139158660
- Description: The NumExpr library is designed to handle and evaluate arithmetic expressions. It enables parsing and analyzing expressions, as well as performing calculations with user-defined functions
UUID: 005f7402-6e25-4d9a-960d-a0ddd50a2fba Repo: https://github.com/bhftbootcamp/NumExpr.jl.git Tree: b8c9033dede13650f3c2631a2981e81c6cb7bacc Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Hi, and congrats on the new package! In my opinion, the name is too short, and too close to the type name |
As another datapoint: from the name, I thought it's a Julia port of (quite popular) https://github.com/pydata/numexpr. Was interested and clicked. |
@gdalle Thank you for your feedback on the proposed package name. I understand your concerns regarding its length and similarity to existing names. However, I’d like to offer some considerations in favor of retaining the chosen name, “NumExpr”:
Our intention is not to confuse but to maintain a clear and functional identity within the Julia ecosystem. |
Brevity is not desirable in Julia packages, and it does not affect functionality. (Sometimes there are good short package names, but you really have to get off this “brevity” train) This name in particular would be pretty much okay. But the existence of https://github.com/pydata/numexpr is a problem. So we have the exact same situation as with Serde now. This is what I meant with you having to do some research on your proposed package names. The best thing to do is to avoid another long discussion and to rename to something like |
@FrancescAlted As the maintainer of https://github.com/pydata/numexpr, would you like to weigh in here? In a situation like this, your “yes” or “no” would likely be the deciding factor for whether this Julia package will be accepted |
@goerz Does NumExpr violate any copyrights? |
That's not the point. We don't go by legalities here. A Julia package |
Thanks for your comment on the package. The Julia community should not hinder individual preferences, as doing so could limit our self-expression and the creative freedom that's essential. @gdalle cc |
The General registry is a shared community resource. If you cannot follow the guidelines, the best course of action might be to use a |
Speaking about guidelines, the name satisfies all the points in juliadocs. If there're more of them, then they all should be very explicit and in one place. Also the other package naming guidelines in CONTRIBUTING.md is unfortunately broken. [noblock] |
But part of the registration process is the community review. With the https://github.com/bhftbootcamp/ organization, you have a pattern of brushing up against the expectations of the community. In fact, not just the Julia community, but the larger open-source community, by reusing the names of existing projects without any relation to those projects. It feels like you just want to do your own thing. That's fine! But, I really think you would be better served by managing your own |
I have proposed a new package naming guideline that will be relevant to this discussion if it receives community approval. (JuliaLang/julia#53514)
Thank you for pointing that out. #101935 |
Hey, that's a bit late, but I personally don't have inconvenient in other projects using the same name. I agree in that perhaps, and provided how close Julia and Python ecosystems are, using the same name wouldn't be the wisest of the decisions, and can lead to some confusion. But again, this not posing a particular problem or inconvenience to me. |
Yeah, personally, I would lean towards keeping the Of course, if @DeevsDeevs comes around to renaming to the recommended |
@goerz So if FrancesAlted has no problems with us using this package name, i believe we want to continue with it. |
I oppose this name for 3 reasons:
This applies directly to this case. NumericalExpressions is a better name than NumExpr for the General registry.
I think that each of 1 and 2 alone would be sufficient to warrant renaming. 3 is more ambiguous. |
@LilithHafner @goerz Thank you again for your feedback, however i don't really agree with your proposal. Some key factors for that are:
Let's aim for a balanced and fair approach, respecting the collaborative spirit and the timing of guideline updates. |
So at this point, the question is whether there's a maintainer who feels "the author should have the last word" outweighs the interests of the community.
Being the cause of a new community guideline is about the strongest rebuke you could possibly get.
You've not given an inch here, so I don't see how this is "balanced". Why are you so resistant to |
Your points 1 & 2 address my point 3. Honestly, my point 3 is not particularly strong anyway. With respect to the Concision/Clarity tradeoff, we try to situate ourselves on the side of clarity. Ideally, we want folks to get a reasonably accurate picture of what the package does from the name alone. Documentation is great and essential, but it's not a substitute for this. Additionally, it is nice for folks to be able to easily guess/remember package names by always using the canonical (i.e full) representation of words. That way you just remember the concepts in the name and don't have to remember the abbreviations too. |
It's not simply about concision and clarity. We are having this discussion in part because of the current naming guidelines. They are simply too rigid and they seem to not follow trends of the modern languages. I don't see people complaining about package names in Rust, Golang or even C++. And in case of the general registry it significantly undermines the goals of being a 'shared community space'. Moreover, using full names hinders creativity and makes the namespace limited and ugly. What if somebody wants to register a package with similar functionality? Are they going to call it 'ExpressionsNumerical' or 'NumericalExpressions2'? Both of these names seem underwhelming to say the least. Lastly, I'm yet to come to a moment where I forget a name of a package I'm actively developing with. IMO, it's easier to remember a good and catchy name than something so general it can be considered terminology. |
That's the whole point we're trying to get across! The package naming conventions are deliberately different from the conventions in these other languages. Different languages have different conventions, and you should follow the conventions of the language you are using.
It is the strong consensus of the Julia community that we want packages to be named that way (with some specific exceptions). We still very much allow for creative names; not every package name has to be of the explicit form of Your ideas on package naming are just not compatible with the General registry, which is why every package registration coming out of your organization has been problematic. If you are unwilling to adapt, please create a |
If you would like to change the current naming guidelines, feel free to make a proposal and solicit community support (e.g. JuliaLang/julia#53514) |
I would also point out that when package names deviate from the normal conventions, that in itself has connotations that can be quite informative. For example, I would expect an For this package, it has none of the connotations that would justify deviating from the conventions. |
Оkay, If the main problem is using a reserved name in Python, what do you think about the name |
USE A LONG DESCRIPTIVE NAME. How many times do we have to explain this? You are clearly not getting the point, so please do not register your packages in General. You should use a
No, the main problem is that you think you are exempt from the community guidelines, simply because you don't like them. |
Great. So can I close this? |
ok, close it |
Please note that if you come around to the community guidelines in the future, you will always be welcome again |