Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Optim at version 1, (keep existing compat) #24

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 7, 2023

This pull request sets the compat entry for the Optim package to 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@michakraus michakraus force-pushed the compathelper/new_version/2023-07-07-09-46-48-947-03609212979 branch from 20a25a4 to 482090d Compare July 7, 2023 09:46
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (7233be6) 48.48% compared to head (482090d) 48.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   48.48%   48.48%           
=======================================
  Files           9        9           
  Lines         264      264           
=======================================
  Hits          128      128           
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michakraus michakraus merged commit 977e23e into main Jul 7, 2023
@michakraus michakraus deleted the compathelper/new_version/2023-07-07-09-46-48-947-03609212979 branch July 7, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants