-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLX] Updated to v0.22.0 #10019
Merged
giordano
merged 5 commits into
JuliaPackaging:master
from
stemann:feature/mlx_next_2024-12
Feb 1, 2025
Merged
[MLX] Updated to v0.22.0 #10019
giordano
merged 5 commits into
JuliaPackaging:master
from
stemann:feature/mlx_next_2024-12
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a15ae27
to
031839e
Compare
4 tasks
32d0075
to
a105c1e
Compare
* Configured libblastrampoline via CMake 3.30 BLA_VENDOR variable, but keeping BLAS/LAPACK INCLUDE_DIRS as the MLX CMakeLists set-up is likely not fully compatible. * Using OpenBLAS for aarch64-unknown-freebsd instead of libblastrampoline. * Using OpenBLAS for armv6l instead of libblastrampoline.
a105c1e
to
f8191f3
Compare
giordano
reviewed
Jan 31, 2025
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
giordano
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They already merged this change (not by me).
357efbf
to
a18986b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently just validating changes to MLX upstream to see if stuff still builds.