Fix reset of LBFGS. (#891)

* Fix reset of LBFGS. * And add a test for NelderMead. * Test begin
JuliaNLSolvers · Dec 17, 2020 · ac7e850 · ac7e850
1 parent 691ba54
commit ac7e850
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/multivariate/solvers/first_order/l_bfgs.jl b/src/multivariate/solvers/first_order/l_bfgs.jl
@@ -154,7 +154,7 @@ function reset!(method, state::LBFGSState, obj, x)
     value_gradient!(obj, x)
     project_tangent!(method.manifold, gradient(obj), x)
 
-    pseudo_iteration = 0
+    state.pseudo_iteration = 0
 end
 function initial_state(method::LBFGS, options, d, initial_x)
     T = real(eltype(initial_x))

diff --git a/test/multivariate/solvers/constrained/fminbox.jl b/test/multivariate/solvers/constrained/fminbox.jl
@@ -137,4 +137,8 @@ end
         optimize(x -> sqrt(x[1]), (g,x)->(g[1]=1/(2*sqrt(x[1]))), [0.0], [10.0], [1.0], Fminbox(m))
         optimize(x -> sqrt(x[1]), [0.0], [10.0], [1.0], Fminbox(m); autodiff=:forwarddiff)
     end
+end
+
+@testset "#865" begin
+    optimize(x -> sum(x), [0.,0.0], [2.0,2.0], [1.,1.0], Fminbox(NelderMead()))
 end