Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer error message for string-based element lookup #72

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Nicer error message for string-based element lookup #72

merged 1 commit into from
Jun 1, 2023

Conversation

mfherbst
Copy link
Member

Fixes #71

@mfherbst mfherbst mentioned this pull request May 31, 2023
Closed
@louisponet
Copy link

I probably like this most out of the 3 proposals in the issue! Too much magic almost never feels good imo.

@jgreener64
Copy link
Collaborator

Looks good.

@mfherbst mfherbst merged commit 144ea82 into master Jun 1, 2023
@mfherbst mfherbst deleted the fix-71 branch June 1, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element can't be found when using String for AtomID
3 participants
@mfherbst @louisponet @jgreener64