Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic fallbacks for getobs and numobs #56

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Conversation

darsnack
Copy link
Member

Adds fallbacks as getindex and length for getobs and numobs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #56 (aad5c72) into main (791fb77) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   88.86%   88.91%   +0.05%     
==========================================
  Files          13       13              
  Lines         413      415       +2     
==========================================
+ Hits          367      369       +2     
  Misses         46       46              
Impacted Files Coverage Δ
src/observation.jl 85.41% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791fb77...aad5c72. Read the comment docs.

@CarloLucibello
Copy link
Member

we should document these fallbacks in the docstrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants