Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port DataLoader from Flux #22

Merged
merged 4 commits into from
Jan 30, 2022
Merged

port DataLoader from Flux #22

merged 4 commits into from
Jan 30, 2022

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Jan 30, 2022

Fix #13

@darsnack
Copy link
Member

Doesn't this just overlap with DataLoaders.jl? That's already LearnBase.jl compatible and more full-featured. Seems like we'd rather port that over.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #22 (a185548) into main (dfc430d) will increase coverage by 0.24%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   88.73%   88.97%   +0.24%     
==========================================
  Files          13       14       +1     
  Lines         355      381      +26     
==========================================
+ Hits          315      339      +24     
- Misses         40       42       +2     
Impacted Files Coverage Δ
src/dataloader.jl 92.30% <92.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc430d...a185548. Read the comment docs.

@CarloLucibello
Copy link
Member Author

I'm not familiar with DataLoaders.jl yet, so I'm porting Flux's one and the corresponding tests first so that we pinpoint a non-breaking replacement for Flux. I will port DataLoaders.jl in a second PR.

@CarloLucibello
Copy link
Member Author

We want to port DataLoaders.jl here and not just reexport, right?

@darsnack
Copy link
Member

darsnack commented Jan 30, 2022

We want to port DataLoaders.jl here and not just reexport, right?

Yeah that's right. And your plan sounds good just want to check in that the long term DataLoader will end up matching DataLoaders.jl. Having a non-breaking version first is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add multitaksing to DataLoader
3 participants