cleanup old builtins #57532
Merged
cleanup old builtins #57532
+91
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54f9083 to
d16b657
Compare
|
FYI, I get this warning when building: ┌ Warning: Failed to precompile expression
│ form = precompile(Tuple{typeof(Base.invokelatest), Any})
└ @ nothing nothing:0 |
The `_apply_pure` function only has one user, and that user is unsound anyways and should not be used, so replace that with equivalent `_call_in_world_total` call and remove unnecessary definitions. The awkward distinction between `invokelatest` and `_call_latest` has not been relevant (and indeed causes performance issues) since kwfunc was introduced in #47157.
d16b657 to
bf78a52
Compare
topolarity
reviewed
Feb 28, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2025
The `_apply_pure` function only has one user, and that user is unsound anyways and should not be used, so replace that with equivalent `_call_in_world_total` call and remove unnecessary definitions. The awkward distinction between `invokelatest` and `_call_latest` has not been relevant (and indeed causes performance issues) since kwfunc was introduced in #47157. (cherry picked from commit 671c6a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_apply_purefunction only has one user, and that user is unsound anyways and should not be used, so replace that with equivalent_call_in_world_totalcall and remove unnecessary definitions.The awkward distinction between
invokelatestand_call_latesthas not been relevant (and indeed causes performance issues) since kwfunc was introduced in #47157.