Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for bitmatrix matmul regression 1.11.1 to 1.11.2 #57387

Merged

Conversation

jakobnissen
Copy link
Contributor

@jakobnissen jakobnissen commented Feb 13, 2025

Fix #56954.

@jakobnissen jakobnissen added the backport 1.11 Change should be backported to release-1.11 label Feb 13, 2025
@jakobnissen
Copy link
Contributor Author

I added the backport 1.11 label, but I have no strong opinions on whether this is backport-worthy.
Note that it does now call iszero in generic matmul, so it may fail for custom number types where addition and multiplication is defined, but Base.zero isn't.

@giordano
Copy link
Contributor

You're already targeting the 1.11 branch, so there's nothing to backport? Or am I missing something?

@jakobnissen
Copy link
Contributor Author

I probably just doesn't understand how backporting works. Are you saying it's done automatically from master with the label? I thought the label was just used for communication.
If the label is going to mess things up, feel free to remove it

@giordano
Copy link
Contributor

Are you saying it's done automatically from master with the label?

Yes

@giordano giordano added linear algebra Linear algebra and removed backport 1.11 Change should be backported to release-1.11 labels Feb 13, 2025
@KristofferC
Copy link
Member

KristofferC commented Feb 13, 2025

But in this case the label + master doesn't really work because LinearAlgebra is moved out to its own separate repo on master but not on 1.11.

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2025
@giordano giordano merged commit 20f842c into JuliaLang:backports-release-1.11 Feb 13, 2025
11 checks passed
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2025
@jakobnissen jakobnissen deleted the backport_matmul branch February 14, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants