-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflection: use CC.findall
instead of _methods_by_ftype
#54212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgtm
Other locations to look at
By looking for |
Some of reflection functions use `_methods_by_ftype`, which doesn't account for the overlay method table, leading to the issues reported in #54189. With this commit, these problems are addressed by switching these reflection functions to use `CC.findall`, aligning them with the other ones. - closes #54189
|
Should the signature reflect that? E.g. |
Some of reflection functions use
_methods_by_ftype
, which doesn't account for the overlay method table, leading to the issues reported in #54189.With this commit, these problems are addressed by switching these reflection functions to use
CC.findall
, aligning them with the other ones.