Add promote_rule
for OneTo
and AbstractUnitRange
#53795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may assume that a
OneTo
behaves like aUnitRange
on promotion. With this, customAbstractUnitRange
types don't need to define promotion rules withOneTo
, and the following works out of the box:There is some potential for ambiguity if a package defines
promote_rule(::AbstractUnitRange, ::CustomUnitRange)
, in which case a workingpromote_rule(::OneTo, ::CustomUnitRange)
becomes ambiguous. However, a similar problem exists forUnitRange
as well, and I think the benefits outweigh the risks.