Make the GC less greedy #50101
Closed
Make the GC less greedy #50101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really don't like this heuristic. I don't think the problem is the number, but the strategy is fundamentally wrong when you have multiple Julias. |
|
The heuristics are all bad anyway, this just makes it safer. Checking the state of the OS isn't really doable, because most OSs will use as much RAM as they can for caching stuff since that's optimal. So there isn't really a correct way outside of the user setting the heapsize if they know they have multiple julia processes. |
|
With 1.10 in the horizon and hopefully #50144 I think I can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change that makes the GC less greedy, this might regress the performance a bit but should reduce the amount of OOMs that people are seeing since 1.9.