elide precompilation in Profile.jl #49613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves about 2ms on my system by checking the precompilation state. This also reorganizes the remaining precompilation calls in the module.
8e4065a to
3d8c07d
Compare
When does it save 2 ms? |
|
Yes I wasn't clear. This is at load, |
|
I don't understand how this could make a difference at that point. This code doesn't run when you import it. It would matter if you run Julia with |
|
I suppose I don't understand. Maybe it was noise. julia/stdlib/Profile/src/Profile.jl Line 1231 in 4bb3a55 |
|
Yes, but that only runs at precompile time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves about 2ms on my system by checking
the precompilation state. This also reorganizes the remaining precompilation calls in the module.