Various precompile fixes #49585
Merged
Various precompile fixes #49585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
May 1, 2023
| if precompile(ps...) | ||
| n_succeeded += 1 | ||
| else | ||
| @warn "Failed to precompile expression" form=statement _module=nothing _file=nothing _line=0 |
There was a problem hiding this comment.
How much noise does this generate?
There was a problem hiding this comment.
0 failures locally so none currently. That's why I was thinking it would be good to have it be noisy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timewith a compiling workload, which without it seemed to cause@timeto miss compilation in some cases the first time it's used (hard to repro)Base.recursive_prefs_mergegiven it's on the list but the varargs version will be hit if you have local preferences@time_importsjust in case