Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize hoisted object allocations #49584

Merged
merged 3 commits into from
May 4, 2023
Merged

Initialize hoisted object allocations #49584

merged 3 commits into from
May 4, 2023

Conversation

pchintalapudi
Copy link
Member

This should prevent objects from being created with uninitialized pointers, while the cost of the memset is likely to be small compared to allocating in a loop.

@pchintalapudi pchintalapudi requested review from vchuravy and vtjnash May 1, 2023 17:35
vtjnash
vtjnash reviewed May 1, 2023
View reviewed changes
vtjnash
vtjnash reviewed May 1, 2023
View reviewed changes
vtjnash
vtjnash reviewed May 1, 2023
View reviewed changes
@vchuravy vchuravy added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 and removed backport 1.8 Change should be backported to release-1.8 labels May 1, 2023
@pchintalapudi
Copy link
Member Author

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@vchuravy vchuravy merged commit 5032a1a into master May 4, 2023
@vchuravy vchuravy deleted the pc/init-julia-licm branch May 4, 2023 21:43
maleadt pushed a commit that referenced this pull request May 5, 2023
@pchintalapudi @maleadt
Initialize hoisted object allocations (#49584)
0be97bb
@maleadt maleadt mentioned this pull request May 5, 2023
Merged
@KristofferC KristofferC mentioned this pull request May 8, 2023
Merged
51 tasks
KristofferC pushed a commit that referenced this pull request May 8, 2023
@pchintalapudi
Initialize hoisted object allocations (#49584)
aefc51f 
(cherry picked from commit 5032a1a)
KristofferC pushed a commit that referenced this pull request May 8, 2023
@pchintalapudi
Initialize hoisted object allocations (#49584)
5d0dcd3
KristofferC pushed a commit that referenced this pull request May 8, 2023
@pchintalapudi
Initialize hoisted object allocations (#49584)
792d907 
(cherry picked from commit 5032a1a)
KristofferC pushed a commit that referenced this pull request May 27, 2023
@pchintalapudi @KristofferC
Initialize hoisted object allocations (#49584)
2a5ede1
KristofferC pushed a commit that referenced this pull request May 27, 2023
@pchintalapudi @KristofferC
Initialize hoisted object allocations (#49584)
f81bada 
(cherry picked from commit 5032a1a)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label May 28, 2023
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@pchintalapudi @kpamnany
Initialize hoisted object allocations (#49584)
217e405
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@pchintalapudi @kpamnany
Initialize hoisted object allocations (#49584)
8b99a77 
(cherry picked from commit 5032a1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pchintalapudi @nanosoldier @vchuravy @vtjnash @KristofferC