Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: some cleanup in gc.c #49577

Merged
merged 2 commits into from
May 2, 2023
Merged

NFC: some cleanup in gc.c #49577

merged 2 commits into from
May 2, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Apr 30, 2023

  • Remove duplicate declaration of jl_gc_wait_for_the_world.
  • Update some comments to reflect that marking is now multithreaded.
  • Move eytzinger tree functions to staticdata.c, since it's no longer used by the GC.

@d-netto d-netto requested review from vchuravy and gbaraldi April 30, 2023 23:20
@d-netto
Copy link
Member Author

d-netto commented May 1, 2023

Seems like CI is green for x86_64-apple-darwin, even though it segfaulted on one of the GC tests (https://buildkite.com/julialang/julia-master/builds/23380#0187d477-c58a-4a4c-a308-e52113c14074):

From worker 2:	 13.133515 seconds (198 allocations: 17.070 KiB)
--
  | From worker 2:	  9.442715 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	  8.452907 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	 31.060096 seconds (6.81 k allocations: 490.418 KiB, 0.10% compilation time)
  | From worker 2:	 16.570991 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	 13.747034 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	 17.792633 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	 48.112748 seconds (3.98 k allocations: 288.633 KiB)
  | From worker 2:	  4.057283 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	  3.349197 seconds (195 allocations: 16.883 KiB)
  | From worker 2:
  | From worker 2:	[37292] signal (11.1): Segmentation fault: 11
  | From worker 2:	in expression starting at none:0
  | From worker 2:	  2.414891 seconds (195 allocations: 16.883 KiB)
  | From worker 2:	  9.823090 seconds (3.98 k allocations: 288.703 KiB)
  | gc                                               (2) \|    89.15 \|   0.00 \|  0.0 \|       5.84 \|  1858.36

@d-netto d-netto added the DO NOT MERGE Do not merge this PR! label May 1, 2023
@d-netto d-netto force-pushed the dcn/gc-minor-cleanup branch from a2d4d20 to e5e8ded Compare May 2, 2023 01:07
@d-netto d-netto added merge me PR is reviewed. Merge when all tests are passing and removed DO NOT MERGE Do not merge this PR! labels May 2, 2023
@d-netto
Copy link
Member Author

d-netto commented May 2, 2023

Seems fine after #49579.

@vchuravy vchuravy merged commit 1a973c7 into master May 2, 2023
@vchuravy vchuravy deleted the dcn/gc-minor-cleanup branch May 2, 2023 03:46
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants