Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add cross-compile prefix for CC twice #49575

Merged
merged 2 commits into from
May 5, 2023

Conversation

benlorenz
Copy link
Contributor

make re-exports changed environment variables to subprocesses, this causes the make subprocess for the src or deps folders to have this applied a second time.

This was observed while trying to build libjulia for Yggdrasil (JuliaPackaging/Yggdrasil#6543) which has CC=cc in the environment, the main make process then changes this to CC=aarch64-apple-darwin20-clang (cc is clang in this case). But the subprocess make -C src will then try to use

CC=aarch64-apple-darwin20-aarch64-apple-darwin20-clang

which fails and then falls back to $(CROSS_COMPILE)gcc which is not what we want to use for this platform.

This assignment was added recently by @vtjnash in #49081
cc: @giordano @fingolfin

make reexports changed environment variables to subprocesses
@vchuravy vchuravy requested a review from vtjnash May 2, 2023 16:54
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 2, 2023
@KristofferC KristofferC merged commit ef359e3 into JuliaLang:master May 5, 2023
@benlorenz benlorenz deleted the bl/xcprefix branch May 5, 2023 10:38
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants