don't add cross-compile prefix for CC twice #49575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
re-exports changed environment variables to subprocesses, this causes the make subprocess for the src or deps folders to have this applied a second time.This was observed while trying to build libjulia for Yggdrasil (JuliaPackaging/Yggdrasil#6543) which has
CC=cc
in the environment, the main make process then changes this toCC=aarch64-apple-darwin20-clang
(cc is clang in this case). But the subprocessmake -C src
will then try to usewhich fails and then falls back to
$(CROSS_COMPILE)gcc
which is not what we want to use for this platform.This assignment was added recently by @vtjnash in #49081
cc: @giordano @fingolfin