Revise jl_timing prints for dlopen
#49560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bab27d to
2545791
Compare
By special request, this changes our `dlopen` logic to include the actually-opened filepath. For convenience, the base filename is listed first. This change also fixes a bug in `gnu_basename` where Windows filepaths were not being scanned for '\\' correctly.
2545791 to
ac1fedb
Compare
KristofferC
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the profiling metadata for
DL_OPENto include both the full requested library name and the path to the resolved handle:Also fixes a bug in
gnu_basenamewhere Windows filepaths were not being scanned for\correctly.