Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate global non-const variables in bundled jlls with types #49542

Merged
merged 1 commit into from
Apr 28, 2023
Merged

annotate global non-const variables in bundled jlls with types #49542

merged 1 commit into from
Apr 28, 2023

Conversation

KristofferC
Copy link
Member

Seems reasonable to do.

@KristofferC KristofferC requested a review from staticfloat April 27, 2023 14:59
vtjnash
vtjnash reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete a lot of this instead? It is somewhat costly, and could be lazily computed only when actually needed

@staticfloat
Copy link
Member

How can we lazily compute it?

@KristofferC KristofferC merged commit ee7538e into master Apr 28, 2023
@KristofferC KristofferC deleted the kc/jll_globals branch April 28, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @staticfloat @vtjnash