Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color compilation with red in tracy during recompilation #49524

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 26, 2023

This makes them kind of obvious and then you can click on them and see what methods ended up getting recompiled. In the screenshot below, we can see that code loading got recompiled.

image

The red bar to the right is code loading getting recompiled... Again! (this is all during loading of a single package)

@IanButterworth
Copy link
Member

Colors have some meaning in ProfileView and the vscode profile canvas etc. Does this match that?

@KristofferC
Copy link
Member Author

ProfileView has it as a dynamic dispatch (not really applicable here). I don't know what it means in vscode.

@IanButterworth
Copy link
Member

Sounds good. If aligning them makes sense it can always happen later

@topolarity
Copy link
Member

This is a good marker to have, but I want to bikeshed on the color.

I've been wanting to carve out some "color space" for the Julia runtime, so that user-level traces/colors are not drowned out by the built-in runtime trace events. My target is just 1 default "runtime event" color and 1 or 2 "special" runtime event colors, and I'd prefer that those colors be a bit less "loud" than this bold red.

Feel free to take a stab at a new palette (or re-use the existing orange we use for special GC events). The idea is that they should be easy to spot when you're looking for them, but not difficult to ignore otherwise.

Otherwise, I'll play around myself today and see if I can propose an alternative

@KristofferC
Copy link
Member Author

I changed to the same color as the GC one now. I don't mind much what color is used, as long as it somewhat sticks out from the reset of the runtime zones.

@KristofferC KristofferC merged commit ced696d into master Apr 28, 2023
@KristofferC KristofferC deleted the kc/color branch April 28, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants