Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow showing of StepRangLen{T} with generic T #49516

Merged
merged 3 commits into from
May 5, 2023
Merged

Allow showing of StepRangLen{T} with generic T #49516

merged 3 commits into from
May 5, 2023

Conversation

SamuelBadr
Copy link
Contributor

For types that don't support == with Int64 (but do support iszero), printing StepRangLens currently fails.

@SamuelBadr
Allow showing of StepRangLen{T} with generic T
93f262e 
For types that don't support `==` with `Int64` (but do support `iszero`), printing `StepRangLen`s currently fails.
@jishnub
Copy link
Contributor

jishnub commented Apr 26, 2023

Could you add a test?

@jishnub jishnub added needs tests Unit tests are required for this change ranges Everything AbstractRange labels Apr 26, 2023
@jishnub jishnub removed the needs tests Unit tests are required for this change label Apr 28, 2023
@jishnub jishnub requested a review from oscardssmith April 28, 2023 06:23
@jishnub jishnub added the backport 1.9 Change should be backported to release-1.9 label Apr 28, 2023
@oscardssmith
Copy link
Member

why does this have a backport label?

@jishnub
Copy link
Contributor

jishnub commented Apr 28, 2023

It's a bugfix, so doesn't a backport seem reasonable?

@oscardssmith
Copy link
Member

did this work in 1.8 and break later? otherwise imo it's a feature

@jishnub jishnub removed the backport 1.9 Change should be backported to release-1.9 label Apr 28, 2023
@KristofferC
Copy link
Member

did this work in 1.8 and break later? otherwise imo it's a feature

Fixing bugs is not features.

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label May 4, 2023
@IanButterworth IanButterworth added the backport 1.9 Change should be backported to release-1.9 label May 5, 2023
@IanButterworth IanButterworth merged commit ee95843 into JuliaLang:master May 5, 2023
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label May 5, 2023
@dkarrasch dkarrasch mentioned this pull request May 5, 2023
Closed
@KristofferC KristofferC mentioned this pull request May 8, 2023
Merged
51 tasks
KristofferC pushed a commit that referenced this pull request May 8, 2023
@SamuelBadr
Allow showing of StepRangLen{T} with generic T (#49516)
db0b126 
(cherry picked from commit ee95843)
KristofferC pushed a commit that referenced this pull request May 8, 2023
@SamuelBadr
Allow showing of StepRangLen{T} with generic T (#49516)
145779c 
(cherry picked from commit ee95843)
KristofferC pushed a commit that referenced this pull request May 27, 2023
@SamuelBadr @KristofferC
Allow showing of StepRangLen{T} with generic T (#49516)
be67a40 
(cherry picked from commit ee95843)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label May 28, 2023
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@SamuelBadr @kpamnany
Allow showing of StepRangLen{T} with generic T (#49516)
ece0f34 
(cherry picked from commit ee95843)
@SamuelBadr SamuelBadr deleted the patch-1 branch February 10, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith Awaiting requested review from oscardssmith

Assignees
No one assigned
Labels
ranges Everything AbstractRange
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamuelBadr @jishnub @oscardssmith @KristofferC @IanButterworth