instrument jl_load_dynamic_library to the profiler
#49496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d983d55 to
cb3f4aa
Compare
cb3f4aa to
b6016fa
Compare
topolarity
approved these changes
Apr 25, 2023
|
Yeah, that goto usage seems totally gratuitous. Would make sense if there was some cleanup before the return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see how much of the jll initialization time was due to opening dynamic libraries:
I had to change some of the
gotos toreturndue to the cleanup attribute not working very well withgoto. I don't really see whygotowas used in the first place but maybe I miss something.