Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticdata: make hookup of code instances correct #48751

Merged
merged 1 commit into from
Feb 21, 2023
Merged

staticdata: make hookup of code instances correct #48751

merged 1 commit into from
Feb 21, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 21, 2023

Previously we would double-account for many of these, leading to occasional chaos. Try to avoid serializing code that does not belong to this incremental compilation session package.

Refs: #48723

@vtjnash vtjnash requested a review from vchuravy February 21, 2023 21:06
@vchuravy
Copy link
Member

cc: @timholy

@vchuravy
Copy link
Member

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

vchuravy
vchuravy approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me

@vtjnash
staticdata: make hookup of code instances correct
bcc6d71 
Previously we would double-account for many of these, leading to
occasional chaos. Try to avoid serializing code that does not belong to
this incremental compilation session package.

Refs: #48723
@vtjnash vtjnash force-pushed the jn/staticdata-fixes-code branch from 8eed0e0 to bcc6d71 Compare February 21, 2023 21:21
@vtjnash vtjnash merged commit 81f366d into master Feb 21, 2023
@vtjnash vtjnash deleted the jn/staticdata-fixes-code branch February 21, 2023 23:34
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Feb 22, 2023
@vchuravy vchuravy mentioned this pull request Feb 22, 2023
Merged
@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC KristofferC mentioned this pull request Mar 3, 2023
Merged
50 tasks
@vchuravy vchuravy mentioned this pull request Mar 3, 2023
Merged
vchuravy added a commit that referenced this pull request Mar 3, 2023
@vchuravy
staticdata: make hookup of code instances correct (#48751)
878cb20 
Previously we would double-account for many of these, leading to
occasional chaos. Try to avoid serializing code that does not belong to
this incremental compilation session package.

Refs: #48723
(cherry picked from commit 81f366d)
vchuravy added a commit that referenced this pull request Mar 3, 2023
@vchuravy
staticdata: make hookup of code instances correct (#48751)
83fe7eb 
Previously we would double-account for many of these, leading to
occasional chaos. Try to avoid serializing code that does not belong to
this incremental compilation session package.

Refs: #48723
(cherry picked from commit 81f366d)
vchuravy pushed a commit that referenced this pull request Mar 3, 2023
@vtjnash @vchuravy
staticdata: make hookup of code instances correct (#48751)
65a025f 
Previously we would double-account for many of these, leading to
occasional chaos. Try to avoid serializing code that does not belong to
this incremental compilation session package.

Refs: #48723
(cherry picked from commit 81f366d)
KristofferC added a commit that referenced this pull request Mar 6, 2023
@KristofferC
Merge pull request #48881 from JuliaLang/vc/backports-1.9
be9df3f 
[release-1.9] Backport #48751 and #48832
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
@timholy timholy mentioned this pull request Jan 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @vchuravy @nanosoldier @KristofferC