-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prohibit tabs in whitespace check #48709
Conversation
bump |
I like this, in fact, so much so that I decided to purge tabs from other kinds of files as well. The code in When this gets merged, it would be good to keep at least two commits: one that changes the whitespace and one that changes the check script. We want these separate so the whitespace one can be ignored in blame history. The order of the first two commits should be reversed, however, since the tests will fail after the first commit without the second one. |
fbb66f5
to
c8a096f
Compare
c8a096f
to
36f6826
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me at this point. Should not be squashed—we want to keep both commits separate!
@KristofferC, do you want to add the whitespace fix commit to the blameless file? |
In general, tabs do not appear in well-formatted Julia source code. This automates that check.
Is a superset of and closes #48697
This should possibly also cover other languages, but I don't know what our style conventions are for those languages and they are presumably less important to cover with this check.
This Does Not mean Julia code with tabs will error/warn/etc. It only effects the style enforcement of source code in this repo.