-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenBLAS_jll] Upgrade to new build optimised for PowerPC #48689
Conversation
This only difference compared to previous build is that this one enables use of dynamic architecture detection also for the PowerPC architecture.
Can you also update the source recipe here? |
Uhm, where exactly? In https://github.com/JuliaLang/julia/blob/80dc13595c0aa29062705547debab679b5735c08/deps/openblas.mk I don't see anything PowerPC-specific (apart from a patch). Maybe I should just delete Lines 834 to 835 in e536c77
|
That seems about right. |
Yeah or just set dynamic arch to true |
12583f1
to
039a523
Compare
Not relevant for this PR, but it would be nice for all the logic to set the various OPENBLAS build options to live in openblas.mk. |
If you just don't set |
039a523
to
12583f1
Compare
Ok, done! To be honest I was a bit lost among those options 😅 |
12583f1
to
e5aaf8f
Compare
Yeah, it is quite a maze. it would be nice to refactor those and put them all in openblas.mk. |
Running Nice! |
I spoke to soon. It looks like we only built Power9...
|
Hm still getting a seqfault on Power8, but this time I actually saw it build many Power6, Power8, and Power9...
|
What is the compiler version and make command used to build openblas? Are you trying it on POWER8 or POWER9? |
This was with:
Slightly surprised thought this was a Power8 cluster xD |
Thanks, I can recreate it. Will debug this. |
This is fixed here OpenMathLib/OpenBLAS#3718 |
openblas 0.3.22 will have the fix included. |
Good to go now? |
Thanks. looks good. |
* [OpenBLAS_jll] Upgrade to new build optimised for PowerPC This only difference compared to previous build is that this one enables use of dynamic architecture detection also for the PowerPC architecture. --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> (cherry picked from commit aacfcf0)
* [OpenBLAS_jll] Upgrade to new build optimised for PowerPC This only difference compared to previous build is that this one enables use of dynamic architecture detection also for the PowerPC architecture. --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> (cherry picked from commit aacfcf0)
This only difference compared to previous build is that this one enables use of dynamic architecture detection also for the PowerPC architecture.
Ref: https://discourse.julialang.org/t/building-openblas-for-powerpc-defaults-to-power8/93972.