Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate type of Task.queue field #48420

Merged
merged 2 commits into from
May 5, 2023
Merged

annotate type of Task.queue field #48420

merged 2 commits into from
May 5, 2023

Conversation

JeffBezanson
Copy link
Member

This is apparently a common source of false positives in JET.

@JeffBezanson
annotate type of Task.queue field
da48fef 
This is apparently a common source of false-positives in JET.
vtjnash
vtjnash reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is entirely correct, since there's no reason to expect the user hasn't put another kind of queue here.

vtjnash
vtjnash reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps hide this behind invokelatest instead?

@JeffBezanson
Copy link
Member Author

Can we really not consider this field private??

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label May 4, 2023
@KristofferC KristofferC merged commit 6b8ebb3 into master May 5, 2023
@KristofferC KristofferC deleted the jb/taskqueuetype branch May 5, 2023 06:33
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @vtjnash @KristofferC @DilumAluthge