Stop renumbering statements in inference proper #48022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
f346350 to
3f0b8ce
Compare
aviatesk
reviewed
Dec 29, 2022
| @@ -742,13 +742,9 @@ function type_annotate!(interp::AbstractInterpreter, sv::InferenceState, run_opt | |||
| body[i] = annotate_slot_load!(undefs, i, sv, expr) # 1&2 | |||
| ssavaluetypes[i] = widenslotwrapper(ssavaluetypes[i]) # 4 | |||
| else # i.e. any runtime execution will never reach this statement | |||
| any_unreachable = true | |||
There was a problem hiding this comment.
Maybe move this assignment into the else block below?
That's true for things during the optimization, but one of the first things it does it schedule the reachable basic blocks into dominance order, which drops unreachable code. |
|
SGTM. It was odd to have this optimization here |
I don't think there's any good reason to try to delete the statements here. The very next thing we do is to convert to IRCode which drops dead code anyway, so this just seems redundant. In addition, it complicates Cthulhu-like analysis, which now has to track an extra set of statement numbers.
3f0b8ce to
908bc08
Compare
aviatesk
pushed a commit
that referenced
this pull request
Feb 22, 2023
I don't think there's any good reason to try to delete the statements here. The very next thing we do is to convert to IRCode which drops dead code anyway, so this just seems redundant. In addition, it complicates Cthulhu-like analysis, which now has to track an extra set of statement numbers.
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 2, 2023
After JuliaLang/julia#48022 the renumbering of `interp.remarks` and `interp.effects` are unnecessary. This may lead to printing them on wrong statements.
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 2, 2023
After JuliaLang/julia#48022 the renumbering of `interp.remarks` and `interp.effects` are unnecessary. This may lead to printing them on wrong statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's any good reason to try to delete the statements here. The very next thing we do is to convert to IRCode which drops dead code anyway, so this just seems redundant. In addition, it complicates Cthulhu-like analysis, which now has to track an extra set of statement numbers.