generalize a bunch of boiler-plate type code for creating integers #4737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes a lot of code in
int.jl
, with the goal of making it easier to create new bitstypes. While I realize immutable types have rather stolen the show, bitstypes are sometimes still nice. This reduces the number of boilerplate methods necessary to create a minimal bits type by 24!@JeffBezanson @StefanKarpinski @ViralBShah OK to merge?
I'm also thinking of adding some generic convert, promote_rule, and arithmetic functions so that you can just call
bitstype <: Signed
(or Unsigned) and everything would pretty much just work.