Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a small mistake in timing code. #45714

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix a small mistake in timing code. #45714

merged 1 commit into from
Jun 17, 2022

Conversation

chflood
Copy link
Member

@chflood chflood commented Jun 16, 2022

We were using the wrong start time when measuring gc pause time.

@oscardssmith
Copy link
Member

oscardssmith commented Jun 16, 2022 •
edited
Loading

That will make GCBenchmark results make a lot more sense.

@oscardssmith oscardssmith added GC Garbage collector bugfix This change fixes an existing bug merge me PR is reviewed. Merge when all tests are passing labels Jun 16, 2022
@oscardssmith oscardssmith merged commit 886d2a4 into JuliaLang:master Jun 17, 2022
@oscardssmith oscardssmith mentioned this pull request Jun 17, 2022
Closed
3 tasks
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chflood @oscardssmith @DilumAluthge