effects: change the overlayed::Bool property to nonoverlayed::Bool
#44786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28ebd99 to
7d527cf
Compare
7d527cf to
10b4114
Compare
67 tasks
|
I think I'd keep the positive sense for method matches and method tables where the answer is strict and use |
10b4114 to
351902c
Compare
|
Thanks @Keno, that sounds more reasonable. I applied all your suggestions. |
overlayed::Bool property to nooverlayed::Booloverlayed::Bool property to nonoverlayed::Bool
The current naming of `overlayed` is a bit confusing since `overlayed === true`, which is the conservative default value, actually means "it _may_ be overlayed" while `overlayed === false` means "this is absolutely not overlayed". I think it should be named as `nonoverlayed`, and then a query name like `is_nonoverlayed` would be more sensible than the alternative `is_overlayed`, which actually should be something like `can_be_overlayed`.
351902c to
18432d7
Compare
aviatesk
added a commit
that referenced
this pull request
Mar 31, 2022
aviatesk
added a commit
that referenced
this pull request
Mar 31, 2022
#44786) The current naming of `overlayed` is a bit confusing since `overlayed === true`, which is the conservative default value, actually means "it _may_ be overlayed" while `overlayed === false` means "this is absolutely not overlayed". I think it should be named as `nonoverlayed`, and then a query name like `is_nonoverlayed` would be more sensible than the alternative `is_overlayed`, which actually should be something like `can_be_overlayed`.
aviatesk
added a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current naming of
overlayedis a bit confusing sinceoverlayed === true, which is the conservative default value, actuallymeans "it may be overlayed" while
overlayed === falsemeans"this is absolutely not overlayed".
I think it should be named as
nonoverlayed, and then a query name likeis_nonoverlayedwould be more sensible than the alternativeis_overlayed, which actually should be something likecan_be_overlayed.