Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC/Parallel marking #44643

Closed
wants to merge 28 commits into from
Closed

GC/Parallel marking #44643

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4417f76
parallel gc
Mar 16, 2022
6905de0
mach handler fix
Apr 10, 2022
48c6fda
typo
Apr 10, 2022
733fc50
no need for locking
Apr 10, 2022
dccb37e
cleanup
Apr 10, 2022
d55923d
minor change in thread recruitment
Apr 11, 2022
1bd9f41
overflow fix
Apr 13, 2022
530f3fd
Merge branch 'master' into dcn/gc
d-netto Apr 13, 2022
1b51d5b
Merge branch 'dcn/gc' of https://github.com/d-netto/julia into dcn/gc
Apr 13, 2022
ed6783c
always trigger ws
Apr 14, 2022
c172b9d
no circ buffer for now
Apr 21, 2022
33afea6
panic'ing on public queue overflow. TODO: resize it
Apr 23, 2022
49b5c84
fix in overflow condition
Apr 23, 2022
fa222ed
unused func
Apr 23, 2022
4ee9ea9
started to implement spin master
d-netto May 2, 2022
78d8359
spin master fixes
d-netto May 2, 2022
a0116d6
spin master working; TODO: stress test
d-netto May 2, 2022
f48bffb
Merge branch 'master' into dcn/gc
d-netto May 25, 2022
aecc2ac
started to implement queue resize
May 25, 2022
e60dd24
removed old bpftrace probes
May 25, 2022
8864ee4
actually freeing ws buffers
May 25, 2022
e048228
Apply suggestions from code review
d-netto May 25, 2022
5b528db
formatting + small change in atomics ordering
May 28, 2022
0ae4534
Merge branch 'dcn/gc' of https://github.com/d-netto/julia into dcn/gc
May 28, 2022
24d6c94
off by one
May 28, 2022
02213b3
larger init_size
May 28, 2022
82dbe34
small fix in termination protocol
Jun 1, 2022
e6a9e3c
Merge branch 'master' into dcn/gc
d-netto Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/gc-debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,6 +1275,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
jl_set_safe_restore(old_buf);
return;
}
jl_gc_mark_cache_t *gc_cache = &ptls->gc_cache;
void **top = sp.pc + pc_offset;
jl_gc_mark_data_t *data_top = sp.data;
sp.data = ptls->gc_cache.data_stack;
Expand All @@ -1285,7 +1286,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
const char *prefix = isroot ? "r--" : " `-";
isroot = 0;
if (pc == gc_mark_label_addrs[GC_MARK_L_marked_obj]) {
gc_mark_marked_obj_t *data = gc_repush_markdata(&sp, gc_mark_marked_obj_t);
gc_mark_marked_obj_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_marked_obj_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1296,7 +1297,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
isroot = 1;
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_scan_only]) {
gc_mark_marked_obj_t *data = gc_repush_markdata(&sp, gc_mark_marked_obj_t);
gc_mark_marked_obj_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_marked_obj_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1307,7 +1308,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
isroot = 1;
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_finlist]) {
gc_mark_finlist_t *data = gc_repush_markdata(&sp, gc_mark_finlist_t);
gc_mark_finlist_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_finlist_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1317,7 +1318,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
isroot = 1;
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_objarray]) {
gc_mark_objarray_t *data = gc_repush_markdata(&sp, gc_mark_objarray_t);
gc_mark_objarray_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_objarray_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1328,7 +1329,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
jl_(jl_typeof(data->parent));
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_obj8]) {
gc_mark_obj8_t *data = gc_repush_markdata(&sp, gc_mark_obj8_t);
gc_mark_obj8_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_obj8_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1341,7 +1342,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
jl_(jl_typeof(data->parent));
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_obj16]) {
gc_mark_obj16_t *data = gc_repush_markdata(&sp, gc_mark_obj16_t);
gc_mark_obj16_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_obj16_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1354,7 +1355,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
jl_(jl_typeof(data->parent));
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_obj32]) {
gc_mark_obj32_t *data = gc_repush_markdata(&sp, gc_mark_obj32_t);
gc_mark_obj32_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_obj32_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1367,7 +1368,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
jl_(jl_typeof(data->parent));
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_stack]) {
gc_mark_stackframe_t *data = gc_repush_markdata(&sp, gc_mark_stackframe_t);
gc_mark_stackframe_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_stackframe_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand All @@ -1379,7 +1380,7 @@ NOINLINE void gc_mark_loop_unwind(jl_ptls_t ptls, jl_gc_mark_sp_t sp, int pc_off
}
else if (pc == gc_mark_label_addrs[GC_MARK_L_module_binding]) {
// module_binding
gc_mark_binding_t *data = gc_repush_markdata(&sp, gc_mark_binding_t);
gc_mark_binding_t *data = gc_repush_markdata(gc_cache, &sp, gc_mark_binding_t);
if ((jl_gc_mark_data_t *)data > data_top) {
jl_safe_printf("Mark stack unwind overflow -- ABORTING !!!\n");
break;
Expand Down
Loading