RFC: Make self-inplace broadcast vectorlizable based on our effect inference #43185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivdep to make a .+= 1 vectorlizablea .+= 1 vectorlizable
a .+= 1 vectorlizablea .+= 1 vectorlizable when a isa Array
2bf16ee to
0543f5d
Compare
a .+= 1 vectorlizable when a isa ArrayForce to derive `effects` during inference stage. Co-Authored-By: Takafumi Arakaki <29282+tkf@users.noreply.github.com>
|
Can you comment on the status here -- does this cause problems, and are there possible alternatives? Would still be nice to solve #43153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found by #43153, self-inplace broadcast with dimension larger than 1 won't be vectorlized by LLVM, as it fails to prove
a[I]andextrude(a)[I]share the same access pattern.#43852 makes it possible to fix it on julia side, as
@simd ivdepshould be safe ifbc[I]is proven to be effect_free, anddestis not self-aliased.Currently the self-aliasing check for
destis pure type-based to avoid binary bloat.