-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the cmdlineargs
tests on Buildkite
#42118
Conversation
Is buildkite forcing threads to be enabled? If so, that is a buildkite bug. |
In our Buildkite setup, we have it set up to run with But this isn't actually specific to Buildkite. If you do I think we want these tests to pass regardless of whether or not the user has set the |
An alternate approach would be to run these particular tests inside a |
The other alternative is to fix the bug described in your MWE in #41977 (comment). I have no idea how to fix that bug 😭, which is why I figured I'd patch the tests instead. |
@staticfloat @vtjnash Can I merge this? As mentioned above, this PR is necessary to get Buildkite working. But also, it's necessary to fix the |
We need a way to limit the number of threads Julia spawns with (since we run multiple runners on a giant 128-core system), so we set I say let's merge this as-is, then revisit. |
(cherry picked from commit e1669b6)
(cherry picked from commit e1669b6)
(cherry picked from commit e1669b6)
(cherry picked from commit e1669b6)
(cherry picked from commit e1669b6)
This change is necessary to get the
cmdlineargs
tests passing on Buildkite.Ref #41977