Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an additional patch for OpenBLAS. #41842

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Include an additional patch for OpenBLAS. #41842

merged 1 commit into from
Aug 10, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 9, 2021

Fixes dynamic arch detection on certain ARMv8 cores.
See OpenMathLib/OpenBLAS#3060

Closes #39877

Fixes dynamic arch detection on certain ARMv8 cores.
See OpenMathLib/OpenBLAS#3060
@maleadt maleadt added the system:arm ARMv7 and AArch64 label Aug 9, 2021
@maleadt
Copy link
Member Author

maleadt commented Aug 10, 2021

Verified that this works on the ARMv8 system in question:

tim@xavier:/tmp$ ./julia-f8d01c06bc/bin/julia -e 'using InteractiveUtils; versioninfo(verbose=true)'
Julia Version 1.8.0-DEV.322
Commit f8d01c06bc (2021-08-09 15:02 UTC)
Platform Info:
  OS: Linux (aarch64-unknown-linux-gnu)
      Ubuntu 18.04.5 LTS
  uname: Linux 4.9.253-tegra #1 SMP PREEMPT Mon Jul 26 12:19:28 PDT 2021 aarch64 aarch64
  CPU: unknown: 
              speed         user         nice          sys         idle          irq
       #1  1190 MHz      11028 s          0 s       2478 s     785197 s        851 s
       #2  1190 MHz      10410 s          0 s       2043 s     788703 s        162 s
       #3  1190 MHz      21183 s         28 s        995 s     779591 s        209 s
       #4  1190 MHz      11651 s          0 s        902 s     789365 s        138 s
       #5  1190 MHz      19184 s          0 s       1029 s     781332 s        200 s
       #6  1190 MHz      13588 s         59 s        929 s     787007 s        157 s
       #7  1190 MHz      37018 s         28 s       1013 s     763526 s        331 s
       #8  1190 MHz      18771 s          0 s        938 s     781984 s        202 s
       
  Memory: 15.445869445800781 GB (11696.74609375 MB free)
  Uptime: 80217.9 sec
  Load Avg:  0.8  0.23  0.08
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, carmel)
Environment:
  LD_LIBRARY_PATH = /usr/local/cuda-10.2/lib64:
  HOME = /home/tim
  TERM = xterm-256color
  PATH = /usr/local/cuda-10.2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

vs

tim@xavier:/tmp$ JULIA_VERSION=nightly ~/jl
Invalid instruction at 0x7f67a400fc: 0xd5380015

signal (4): Illegal instruction
in expression starting at none:0
gotoblas_dynamic_init at /home/tim/.cache/jl/installs/bin/linux/aarch64/julia-latest-linuxaarch64/bin/../lib/julia/libopenblas64_.so (unknown line)
gotoblas_init at /home/tim/.cache/jl/installs/bin/linux/aarch64/julia-latest-linuxaarch64/bin/../lib/julia/libopenblas64_.so (unknown line)
unknown function (ip: 0x7f7c834a33)
unknown function (ip: 0x7f7c834a33)
Allocations: 2725 (Pool: 2715; Big: 10); GC: 0
Illegal instruction (core dumped)

BSD failure looks unrelated, so I'll go ahead and merge this.

@maleadt maleadt added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Aug 10, 2021
@maleadt maleadt merged commit cd6e67f into master Aug 10, 2021
@maleadt maleadt deleted the tb/openblas_armv8 branch August 10, 2021 06:02
KristofferC pushed a commit that referenced this pull request Aug 25, 2021
Fixes dynamic arch detection on certain ARMv8 cores.
See OpenMathLib/OpenBLAS#3060

(cherry picked from commit cd6e67f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:arm ARMv7 and AArch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on Linux/ARM64
3 participants