-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printf %g/%G format fix for Inf/NaN #41650
Conversation
Uuhh.. Not |
No :) |
I'll get the champagne then, a build failure that's not caused by me missing something 😂 |
Seems like Distributed tests deadlocked on Freebsd, works as intended on other platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please squash PRs like this :) |
Oof, sorry. I still think we shouldn't allow merge commits and just do rebase or squash. |
Merge commits are appropriate sometimes. Core devs often make PRs that are a series of logically separate, staged commits, in which case a merge commit is the right thing to do. A rebase would be ok in those cases but the GitHub UI for rebase-merge sucks and makes it impossible to trace each commit back to the PR that it came from, so that's not ideal. |
Fixes #41631