Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cmd object notes in the Running External Programs section of the manual. #39704

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

AtsushiSakai
Copy link
Contributor

I added Cmd object notes in the Running External Programs section of the manual to fix #19286.

@@ -373,3 +373,13 @@ stages have different latency so they use a different number of parallel workers
saturated throughput.

We strongly encourage you to try all these examples to see how they work.

## `Cmd` Objects
[`Cmd`](@ref) objects can also be used. It can customize them with the `dir` keyword to set the working directory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can also be used directly, since the cmd syntax does also produce Cmd objects. And then adjust the rest of the sentence to say "This way, they may be used to customize ..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I fixed it. PTAL.

AtsushiSakai and others added 2 commits February 19, 2021 07:26
Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
@AtsushiSakai
Copy link
Contributor Author

Thank you. I committed your suggestions.

@Keno Keno merged commit 1699c6a into JuliaLang:master Feb 19, 2021
@AtsushiSakai AtsushiSakai deleted the issue_19286 branch February 19, 2021 04:40
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual: "Running External Programs" does not explain how to change working directory
2 participants