Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for infinite loop when passing 0d array to setindex of n-dim arrays #39608

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Fix for infinite loop when passing 0d array to setindex of n-dim arrays #39608

merged 4 commits into from
Feb 11, 2021

Conversation

BioTurboNick
Copy link
Contributor

@BioTurboNick BioTurboNick commented Feb 11, 2021 •
edited
Loading

This PR fixes the infinite loop noted by @mbauman here: #38019 (comment)

Added a specialization of setindex_shape_check for 0-d arrays.

@ronisbr ronisbr added the arrays [a, r, r, a, y, s] label Feb 11, 2021
@ronisbr ronisbr requested a review from mbauman February 11, 2021 12:00
@mbauman
Copy link
Member

mbauman commented Feb 11, 2021

Could you add [fill(1); rand(2, 2, 2)] as a test case?

@mbauman mbauman added needs tests Unit tests are required for this change backport 1.6 Change should be backported to release-1.6 labels Feb 11, 2021
@BioTurboNick
Copy link
Contributor Author

@mbauman sure, is there a way to guard against an infinite loop in testing, or does that happen automatically?

@vchuravy
Copy link
Member

is there a way to guard against an infinite loop in testing, or does that happen automatically?

It will hang and then the timeout will kill it :)

@mbauman mbauman removed the needs tests Unit tests are required for this change label Feb 11, 2021
@Keno Keno merged commit 296acf2 into JuliaLang:master Feb 11, 2021
@KristofferC KristofferC mentioned this pull request Feb 17, 2021
Merged
52 tasks
KristofferC pushed a commit that referenced this pull request Feb 17, 2021
@BioTurboNick @KristofferC
Fix for infinite loop when passing 0d array to setindex of n-dim arra…
de9832c 
…ys (#39608)

* Fix for infinite loop with 0d array

* Consistency

* More consistency

* Test

(cherry picked from commit 296acf2)
@mbauman mbauman mentioned this pull request Mar 5, 2021
Closed
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@BioTurboNick @ElOceanografo
Fix for infinite loop when passing 0d array to setindex of n-dim arra…
a3fb768 
…ys (JuliaLang#39608)

* Fix for infinite loop with 0d array

* Consistency

* More consistency

* Test
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@BioTurboNick @antoine-levitt
Fix for infinite loop when passing 0d array to setindex of n-dim arra…
c98d5c3 
…ys (JuliaLang#39608)

* Fix for infinite loop with 0d array

* Consistency

* More consistency

* Test
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@BioTurboNick @staticfloat
Fix for infinite loop when passing 0d array to setindex of n-dim arra…
2260906 
…ys (#39608)

* Fix for infinite loop with 0d array

* Consistency

* More consistency

* Test

(cherry picked from commit 296acf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BioTurboNick @mbauman @vchuravy @ronisbr @KristofferC @Keno