Fixes some inference issues #39606
Merged
Fixes some inference issues #39606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
reviewed
Feb 11, 2021
Comment on lines
-223
to
-224
| bail_out_statement(interp::AbstractInterpreter, @nospecialize(t), sv) = t === Bottom | ||
| bail_out_local(interp::AbstractInterpreter, @nospecialize(t), sv) = t === Bottom |
There was a problem hiding this comment.
I added the response to this change here.
4f5b22e to
7c8114c
Compare
This logic is present to avoid asking ill-posed questions after we discover the dataflow is terminated, similar to how we'd remove the code after throw or a constant branch. Refs: #39439 (comment)
This only would matter if we transition a call from T -> Union{}, which
is unlikely to happen, and even less likely to be observed, but it is
more correct this way.
Previously, we might accidentally leave behind content in the fields
that should not be there. For example:
```
julia> code_typed(() -> (TypeVar(:x),), (), optimize=false)
1-element Vector{Any}:
CodeInfo(
@ REPL[1]:1 within `#3'
1 ─ %1 = Main.TypeVar(:x)::Core.Compiler.PartialTypeVar(x, true, true)
│ %2 = Core.tuple(%1)::Core.PartialStruct(Tuple{TypeVar}, Any[Core.Compiler.PartialTypeVar(x, true, true)])
└── return %2
) => Tuple{TypeVar}
julia> ans[1][1].rettype
Core.PartialStruct(Tuple{TypeVar}, Any[Core.Compiler.PartialTypeVar(x, true, true)])
```
7c8114c to
55eca20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In review of #39512, I noticed some other issues in Core.Inference, which I address here.