-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use sparse multiplication for sparse arrays time BitMatrix and BitVector and wrappers #39557
Conversation
I can add some tests if this is deemed the way forward. |
@dkarrasch Can you also take a look? |
Let's add the tests. I'm not sure - but is nanosoldier functional at the moment? |
About the tests... how can we target the fact that the multiplication is the sparse one? |
I think you can do something like
It would be interesting to see whether we have tests that cover the BitVector case. But to make sure we don't regress from where we currently are, let's run Nanosoldier. @nanosoldier |
nanosoldier seems MIA :( |
Sometimes it's actually running but fails to leave a footprint. Unfortunately, I don't know where to look for whether it's running. I'll wait two or three hours and then try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this is carefully written to include "BitVecOrMat
", but otherwise not change current behavior. I'd not expect to learn much from a Nanosoldiers run.
That's what I thought as well - I think it should be good to merge. I think nanosoldier is out of commission (and physical access to MIT is needed to fix it - which is not likely to be approved anytime soon). |
@dkarrasch Please merge if good. |
My attempt to fix #39474
Not really sure about the types renaming, can be rolled back or changed of course.