improve bunch of type stabilities in Core.Compiler
#39549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Feb 6, 2021
Comment on lines
-696
to
+716
| cti, info = precise_container_type(interp, itft, ti, sv) | ||
| cti_info = precise_container_type(interp, itft, ti, sv) | ||
| cti = cti_info[1]::Vector{Any} | ||
| info = cti_info[2]::Union{Nothing,AbstractIterationInfo} | ||
| else | ||
| cti, info = precise_container_type(interp, itft, unwrapva(ti), sv) | ||
| cti_info = precise_container_type(interp, itft, unwrapva(ti), sv) | ||
| cti = cti_info[1]::Vector{Any} | ||
| info = cti_info[2]::Union{Nothing,AbstractIterationInfo} |
There was a problem hiding this comment.
We will not need these hacks once #39305 gets merged.
| @@ -371,7 +371,7 @@ function statement_cost(ex::Expr, line::Int, src::CodeInfo, sptypes::Vector{Any} | |||
| end | |||
| a = ex.args[2] | |||
| if a isa Expr | |||
| cost = plus_saturate(cost, statement_cost(a, -1, src, sptypes, slottypes, params, error_path)) | |||
| cost = plus_saturate(cost, statement_cost(a, -1, src, sptypes, slottypes, union_penalties, params, error_path)) | |||
There was a problem hiding this comment.
This is a true error; otherwise will yield NoMethodError.
aviatesk
commented
Feb 6, 2021
Comment on lines
-17
to
+23
| def_bb = block_for_inst(ir.cfg, ir.new_nodes[op.id - length(ir.stmts)].pos) | ||
| def_bb = block_for_inst(ir.cfg, ir.new_nodes.info[op.id - length(ir.stmts)].pos) | ||
| else | ||
| def_bb = block_for_inst(ir.cfg, op.id) | ||
| end | ||
| if (def_bb == use_bb) | ||
| if op.id > length(ir.stmts) | ||
| @assert ir.new_nodes[op.id - length(ir.stmts)].pos <= use_idx | ||
| @assert ir.new_nodes.info[op.id - length(ir.stmts)].pos <= use_idx |
There was a problem hiding this comment.
These are another "true" errors.
vtjnash
reviewed
Feb 10, 2021
vtjnash
reviewed
Feb 10, 2021
vtjnash
approved these changes
Feb 10, 2021
9ff11fd to
98a6c33
Compare
All of them are detected by JET.jl's self-profiling. The following code will print type-instabilities/type-errors for all code paths reachable from `typeinf(::NativeInterpreter, ::InferenceState)`. ```julia julia> using JET julia> report_call(Core.Compiler.typeinf, (Core.Compiler.NativeInterpreter, Core.Compiler.InferenceState); annotate_types = true) ``` The remaining error reports (e.g. `variable Core.Compiler.string is not defined`) are because of missing imports.
vtjnash
pushed a commit
that referenced
this pull request
Feb 16, 2021
All of them are detected by JET.jl's self-profiling. The following code will print type-instabilities/type-errors for all code paths reachable from `typeinf(::NativeInterpreter, ::InferenceState)`. ```julia julia> using JET julia> report_call(Core.Compiler.typeinf, (Core.Compiler.NativeInterpreter, Core.Compiler.InferenceState); annotate_types = true) ``` The remaining error reports (e.g. `variable Core.Compiler.string is not defined`) are because of missing functionality on error paths. (cherry picked from part of commit 1bc7f43)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…9549) All of them are detected by JET.jl's self-profiling. The following code will print type-instabilities/type-errors for all code paths reachable from `typeinf(::NativeInterpreter, ::InferenceState)`. ```julia julia> using JET julia> report_call(Core.Compiler.typeinf, (Core.Compiler.NativeInterpreter, Core.Compiler.InferenceState); annotate_types = true) ``` The remaining error reports (e.g. `variable Core.Compiler.string is not defined`) are because of missing functionality on error paths.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…9549) All of them are detected by JET.jl's self-profiling. The following code will print type-instabilities/type-errors for all code paths reachable from `typeinf(::NativeInterpreter, ::InferenceState)`. ```julia julia> using JET julia> report_call(Core.Compiler.typeinf, (Core.Compiler.NativeInterpreter, Core.Compiler.InferenceState); annotate_types = true) ``` The remaining error reports (e.g. `variable Core.Compiler.string is not defined`) are because of missing functionality on error paths.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
All of them are detected by JET.jl's self-profiling. The following code will print type-instabilities/type-errors for all code paths reachable from `typeinf(::NativeInterpreter, ::InferenceState)`. ```julia julia> using JET julia> report_call(Core.Compiler.typeinf, (Core.Compiler.NativeInterpreter, Core.Compiler.InferenceState); annotate_types = true) ``` The remaining error reports (e.g. `variable Core.Compiler.string is not defined`) are because of missing functionality on error paths. (cherry picked from part of commit 1bc7f43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of them are detected by JET.jl's self-profiling.
The following code will print type-instabilities/type-errors for
code paths reachable from
typeinf(::NativeInterpreter, ::InferenceState).The remaining error reports (e.g.
variable Core.Compiler.string is not defined)are because of missing imports.
101 possible errors found
20 possible errors found